-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pip install firedrake #4011
Draft
connorjward
wants to merge
107
commits into
master
Choose a base branch
from
connorjward/pip-install
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
pip install firedrake #4011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
This was referenced Feb 6, 2025
leo-collins
reviewed
Feb 20, 2025
4 tasks
To make sure that we can resolve the API.
* Implement firedrake-check in a totally crazy way * Fix (?) library paths for libsupermesh (breaking Thetis)
Since VTK does not have an ARM wheel most downstream packages are not usable.
JHopeCollins
requested changes
Feb 21, 2025
Comment on lines
+414
to
+415
if package_manager == MACOS_HOMEBREW_ARM64: | ||
vars["HDF5_DIR"] = "/opt/homebrew" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
if package_manager == MACOS_HOMEBREW_ARM64: | |
vars["HDF5_DIR"] = "/opt/homebrew" | |
if package_manager == MACOS_HOMEBREW_ARM64: | |
vars["HDF5_DIR"] = "/opt/homebrew" | |
elif package_manager is None: | |
vars["HDF5_DIR"] = vars["PETSC_DIR"]+"/"+vars["PETSC_ARCH"] |
If --no-package-manager
is used then PETSc will be told to download hdf5, and HDF5_DIR
must be set so h5py
knows where to link against.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Die
firedrake-install
! Die! Die! Die!Remaining tasks
make check
User-facing changes
pip install firedrake
pip
.firedrake-configure
script to facilitate installation.firedrake-install
/firedrake-update
remain but spit out a deprecation warning.firedrake-install --doi
will no longer work.Docker
firedrake-vanilla
andfiredrake-complex
have been renamed tofiredrake-vanilla-default
andfiredrake-vanilla-complex
respectively.firedrake
is now installed directly in the container. It is no longer necessary to activate a virtual environment.firedrake
repository is now installed in~/firedrake
instead of~/firedrake/src/firedrake
. The same applies to other packages likegusto
andthetis
inside thefiredrakeproject/firedrake
container.firedrake-vanilla
containers. If your package needs it then please add it to your ownpyproject.toml
or runpip install vtk
.Please see firedrakeproject/gusto#618 as an example switching a workflow to using the new containers.
Developer-facing changes
firedrake-env
container no longer contains PETSc, which is instead built infiredrake-vanilla
.firedrake-env
container.Design choices
Unlike
firedrake-install
,firedrake-configure
is designed to be very, very dumb. All it does is take in a specification of a desired package manager (apt-x86_64
,apt-aarch64
,brew-arm64
) and "arch" (default
orcomplex
) and spits out a string of appropriate system dependencies (--show-system-dependencies
) or PETSc configure options (--show-petsc-configure-options
). You can also pass--no-package-manager
if you aren't using a supported system and this will give you a set of PETSc configure options where everything is downloaded.