Chore: Add support for new timer name in dnf5 #9
Conversation
Signed-off-by: Ryan Finnin Day <[email protected]>
There was a problem hiding this comment.
Thank you for your PR! I'm not using this role on my own since some time but I accept PRs, so thanks for tackling this.
Besides of the import logic, I think this PR is good.
While this now supports dnf5, I'm wondering whether you would also be interested to implement #8 (it's fine if you won't). The dnf5 introduction in this role might be a good opportunity because we already distinguish old and new dnf now. The built-in reboot functionality could only be used for dnf5 then. Though, I realize that reboot functionality seems to be present in certain versions of older dnf as well. Don't know if all distributions lacking that support are already EOL, so maybe we could drop the legacy mechanism altogether but I'm not sure and it would be fine to have this for dnf5 only, when it's easier.
| @@ -1,63 +1,19 @@ | |||
| --- | |||
| # manage dnf bases on the distribution | |||
There was a problem hiding this comment.
I think the conditional import logic can be greatly simplified. As far as I know, ansible_pkg_mgr is either set to dnf for older dnf or to dnf5. This should be enough (when: ansible_pkg_mgr == "dnf5"). Or do you see any problem with this approach?
Thank you for this role. I've been using it on CentOS7, 8, 9 and Fedora 40, 41.
This role began throwing errors when trying to manage a Fedora41 system which introduced dnf5. This changed the package name for dnf-automatic and the timer name.
This commit introduces logic to test for distribution and then apply appropriate dnf config.