fix: validate input schema using json schema validator #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhmd-azeez
force-pushed
the
validate-input-schema
branch
from
77dc6dc to
281657b
Compare
|
not sure why the obsidian plugin is failing to build |
There was a breaking change to the python-pdk. I will fix today. |
mhmd-azeez
commented
Jan 21, 2025
servlets/assembly-ai/main.go
Outdated
Comment on lines
95
to
111
| "type": "object", | ||
| "oneOf": []interface{}{ | ||
| map[string]interface{}{ | ||
| "required": []string{"audio_path"}, | ||
| "not": map[string]interface{}{ | ||
| "required": []string{"audio_base64"}, | ||
| }, | ||
| }, | ||
| map[string]interface{}{ | ||
| "required": []string{"audio_base64"}, | ||
| "not": map[string]interface{}{ | ||
| "required": []string{"audio_path"}, | ||
| }, | ||
| }, | ||
| }, | ||
| "properties": map[string]interface{}{ | ||
| "audio_path": map[string]interface{}{ |
There was a problem hiding this comment.
The simulation can now handle complicated schemas like this too, @nilslice we just need to make sure the API/frontend can also handle it (when displaying it back on the website)
There was a problem hiding this comment.
awesome! i will try to use some of this code to help inform that update.
mhmd-azeez
force-pushed
the
validate-input-schema
branch
from
e533b55 to
d565095
Compare
mhmd-azeez
force-pushed
the
validate-input-schema
branch
from
1688b98 to
b8bbb37
Compare
…-emergency-npm-install-system fix: Makefile was missing npm install step
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://github.com/dylibso/mcp.run/issues/248
Fixes https://github.com/dylibso/mcp.run/issues/265