fix: MoveTabBefore and MoveTabAfter stored procedures same TabOrder h…

[timi-ty]

Fixes #6384

Summary

The issue occurs when attempting to reorder tabs (pages) that have identical TabOrder values. The current implementation of MoveTabBefore and MoveTabAfter procedures fails to handle this edge case correctly.

Changes made

Fixed issue with tab ordering when multiple tabs share the same TabOrder value. Key changes:

1. Added TabId as secondary sorting criteria when TabOrder values are equal
2. Modified tab position logic to correctly handle duplicate TabOrder scenarios:
   • For MoveTabAfter: Places target tab at AfterTab's order + 1
   • For MoveTabBefore: Places target tab at BeforeTab's order - 1
3. Added proper handling of tabs with same TabOrder but different TabIds
4. Implemented final ordering pass that preserves intentional TabOrder gaps while ensuring consistent sequencing
5. Added transaction management for atomic updates

These changes ensure tabs are inserted at the exact specified position regardless of duplicate TabOrder values in the sequence.

Results

The Search Results page was successfully moved between Page 1, Page 2, Page 3 and Page 4 which have the same TabOrder value.

N.B.: My expectation was that the system would use the stored procedures from the most recent versioned SqlDataProvider in which they are available- 07.03.03.SqlDataProvider in this case. However I found that when installing the website, the system used the stored procedures MoveTabBefore and MoveTabAfter defined in DotNetNuke.Data.SqlDataProvider. This is the file that was modified in this PR.

[timi-ty]

@microsoft-github-policy-service agree company="Trilogy"

[valadas]

@timi-ty we have DNN 10 in RC stage and we have done an SQL revamp for v10, which would make this hard to merge for v10 with a git conflict. Could you retarget this fix towards release/10.0.0 branch?