Fix broken verbose reporting of successful tests #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We werre missing passing through the verbosity setting to the trx command, because we were creating a brand new setting class after the fact. Since all the logic in that settings class (defaulting the path) is encapsulated in the Validate method, we can safely just use it when running the command. For dotnet-retest we never do recursive log lookup, and we should preserve the legacy Skipped setting if it's provided too.
|
🧪 Details on Microsoft Windows 10.0.20348from dotnet-retest v42.42.220-pr70 on .NET 8.0.12 with 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We werre missing passing through the verbosity setting to the trx command, because we were creating a brand new setting class after the fact.
Since all the logic in that settings class (defaulting the path) is encapsulated in the Validate method, we can safely just use it when running the command.
For dotnet-retest we never do recursive log lookup, and we should preserve the legacy Skipped setting if it's provided too.