Skip to content

Commit

Permalink
Split and join the result in payments file
Browse files Browse the repository at this point in the history
  • Loading branch information
pskl committed Feb 19, 2025
1 parent ffbe78d commit 44cfcd6
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 6 deletions.
2 changes: 1 addition & 1 deletion app/services/asp/mappers/adresse/indu_etranger_mapper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ def bureaudistribetranger
end

def voiepointgeoetranger
student.address_line1
student.address_line1.split(" | ").join(" ")
end

def districtetranger
Expand Down
2 changes: 1 addition & 1 deletion app/services/asp/mappers/adresse/indu_france_mapper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ module Mappers
module Adresse
class InduFranceMapper < FranceMapper
def pointremise
student.address_line1
student.address_line1.split(" | ").join(" ")
end

def cpltdistribution
Expand Down
8 changes: 4 additions & 4 deletions spec/apis/students_api/sygne/mappers/address_mapper_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@
let(:expected) do
{
address_line1: [data["adrResidenceEle"]["adresseLigne1"], data["adrResidenceEle"]["adresseLigne2"],
data["adrResidenceEle"]["adresseLigne3"], data["adrResidenceEle"]["adresseLigne4"]].join(" "),
data["adrResidenceEle"]["adresseLigne3"], data["adrResidenceEle"]["adresseLigne4"]].join(" | "),
address_postal_code: data["adrResidenceEle"]["codePostal"],
address_city: data["adrResidenceEle"]["libelleCommune"],
address_city_insee_code: data["adrResidenceEle"]["codeCommuneInsee"],
Expand All @@ -28,9 +28,9 @@
before { data["adrResidenceEle"]["adresseLigne2"] = nil }

it "maps addresses correctly" do
expect(mapper.call(data)[:address_line1]).to eq [data["adrResidenceEle"]["adresseLigne1"],
data["adrResidenceEle"]["adresseLigne3"],
data["adrResidenceEle"]["adresseLigne4"]].join(" ")
expect(mapper.call(data)[:address_line1].split(" | ").join(" ")).to eq [data["adrResidenceEle"]["adresseLigne1"],
data["adrResidenceEle"]["adresseLigne3"],
data["adrResidenceEle"]["adresseLigne4"]].join(" ")
end
end
end

0 comments on commit 44cfcd6

Please sign in to comment.