charts: better error handling; backwards-compat #1750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, charts with invalid data were quietly discarded, bubble up the error instead. On loading the data for a <svelte-component> custom element, render a potential validation error message a bit more prominently and with more context. Also, add backwards-compatibility handler (with a warning) for hierarchy charts that still have the "tree" nested one level deeper. The `modifier` key has been removed in v1.26 and is now inferred automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, charts with invalid data were quietly discarded, bubble up
the error instead.
On loading the data for a custom element, render a
potential validation error message a bit more prominently and with more
context.
Also, add backwards-compatibility handler (with a warning) for hierarchy
charts that still have the "tree" nested one level deeper. The
modifierkey has been removed in v1.26 and is now inferredautomatically.