Fix type error in extract_lora.py
: SVD only supports float32
#510
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Running
extract_lora.py
on any model that does not usefloat32
as its default tensor type currently results in aRuntimeError
. This is a significant limitation, as many recent models default tobfloat16
orfloat16
(half precision). The error arises from the use of thetorch.linalg.svd
API, which only supportstorch.float32
. This pull request (PR) addresses the issue by converting tensors tofloat32
(full precision) before executingtorch.linalg.svd
, and then converting them back to their original data type afterwards.