Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NUTCH-3033 Upgrade Ivy to v2.5.2 #803

Merged
merged 16 commits into from
Mar 13, 2024
Merged

NUTCH-3033 Upgrade Ivy to v2.5.2 #803

merged 16 commits into from
Mar 13, 2024

Conversation

lewismc
Copy link
Member

@lewismc lewismc commented Mar 11, 2024

PR for https://issues.apache.org/jira/browse/NUTCH-3033
I was having trouble locally resolving the Ivy version to 2.5.2… I can’t yet figure out why 2.5.1 was being used. I’ll check out the CI log and see if the newer version is used.

@lewismc
Copy link
Member Author

lewismc commented Mar 11, 2024

OK so it looks like the newer Ivy version is being used just fine. The build did however fail with the following

Caused by: java.lang.RuntimeException: Multiple artifacts of the module io.netty#netty-transport-native-kqueue;4.1.84.Final are retrieved to the same file! Update the retrieve pattern to fix this error.

… investigating.

@lewismc
Copy link
Member Author

lewismc commented Mar 11, 2024

Hmmm, I upgraded to 2.5.1 and the CI runs just fine. Looks like there is some regression/additional configuration required with 2.5.2. I’m asking the question over on ivy-user@ mailing list.

@lewismc lewismc closed this Mar 12, 2024
@lewismc lewismc reopened this Mar 12, 2024
@lewismc
Copy link
Member Author

lewismc commented Mar 13, 2024

After lots of trial and error I think I cracked this one. Ultimately there were several places where the optional (-[classifier]) element has to be added to the ivy:retrieve pattern.
This wasn’t particularly intuitive as the ivy documentation is somewhat lacking in this regard however @bodewig pointed me in the right direction on the ivy-user@ mailing list. Thank you for that @boedwig.

This PR is ready for review.

Copy link
Contributor

@sebastian-nagel sebastian-nagel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Looks good! Everything compiles, unit tests pass.

@lewismc lewismc merged commit 4f62dec into apache:master Mar 13, 2024
4 checks passed
@lewismc lewismc deleted the NUTCH-3033 branch March 13, 2024 14:43
@lewismc
Copy link
Member Author

lewismc commented Mar 13, 2024

Thanks @sebastian-nagel 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants