Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vnext #280

Closed
wants to merge 14 commits into from
Closed

Vnext #280

wants to merge 14 commits into from

Conversation

adrianoc
Copy link
Owner

Thank you for your contribution

First, thank you for taking the time to help improving Cecilifier; I really appreciate it.

That being said, in order to help improving Cecilifier codebase quality please consider the following check list:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • My code is following the existing conventions. I understand that even the existing code some times does not follow the conventions but please, strive to follow whatever is the most common used convention used in the codebase.
  • I have double checked that my code is not adding duplications
  • Front-end (web site) related fixes/features were tested manually (as of today we don't have an automated test for that).
  • I have made corresponding changes to the documentation (README.md, website, etc) ?
  • I have verified that there is an issue open describing the actual problem/feature and have referenced it in the commit message that fixes/implement it.

Description

Please, describe what your PR is adding/changing.

adrianoc and others added 13 commits April 10, 2024 08:06
previous implementation was not taking 'type parameters'  into account while tracking generated methods leading to crashes.
this allows me to track progress using milestones as I'll close the issue as soon as it is fixed in any branch
Due to issue #277 tests were expecting DateTime to be resolved to 'assembly.MainModule.TypeSystem.DateTime'
'Node.js 16 actions are deprecated. Please update the following actions to use Node.js 20: actions/checkout@v3, actions/setup-dotnet@v3. For more information see: https://github.blog/changelog/2023-09-22-github-actions-transitioning-from-node-16-to-node-20/'
@adrianoc adrianoc marked this pull request as draft April 11, 2024 15:52
@adrianoc adrianoc marked this pull request as ready for review April 11, 2024 15:52
It looks like there's a [bug](codecov/codecov-action#1292) in v4
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@adrianoc adrianoc closed this Apr 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants