Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Promoting staging to production (feb/2024) #260

Merged
merged 14 commits into from
Feb 2, 2024
Merged

Promoting staging to production (feb/2024) #260

merged 14 commits into from
Feb 2, 2024

Conversation

adrianoc
Copy link
Owner

@adrianoc adrianoc commented Feb 2, 2024

ecbb4d1 update generated csproj to match dotnet version (8.0)
056c90e bumps version to 2.8.0
3baccc9 use monaco 'markers' to report compilation errors in snippets (#258)
d4d35af updates monaco editor to version 0.45.0 and cleans up web csproj to only include monaco minified files
247c75c fixes assignment to ref storage (#259)
c05185d fix project build status url in README file
dd9b475 fix broken test expectations due to new behavior in .Net 8.0
b7ac6f4 update js-snackbar to v1.6, year to 2024 and some minor cosmetic tweaks
3e85383 cosmetic changes and minor fixes in the tooltips
a37beec changes ci to build/run tests on .Net 8.0
e748644 updates NUnit to version 4.0 and Microsoft.NET.Test.Sdk to 17.8.0
89654a3 bumps supported C# language version to 12
ebad4c8 update csproj to .net 8.0

Up until .Net 7.0, interfaces had 2 attributes: Interface + Abstract
In .Net 8.0 interfaces are emited with a third one: BeforeFieldInit

Can be verified with the following bash script:

cd /tmp
rm -rf test
mkdir test
cd test
echo "public interface IFoo {}"  > itf.cs

echo '<Project Sdk="Microsoft.NET.Sdk"><PropertyGroup><TargetFramework>net7.0</TargetFramework></PropertyGroup></Project>'  >  itf.csproj
docker run -it -v /tmp/test/:/code mcr.microsoft.com/dotnet/sdk:7.0 bash -c "cd /code;
dotnet build;
dotnet tool install -g ilspycmd;
DOTNET_ROLL_FORWARD=LatestMajor /root/.dotnet/tools/ilspycmd -il /code/bin/Debug/net7.0/itf.dll > 7.il
"

echo '<Project Sdk="Microsoft.NET.Sdk"><PropertyGroup><TargetFramework>net8.0</TargetFramework></PropertyGroup></Project>'  >  itf.csproj
docker run -it -v /tmp/test/:/code mcr.microsoft.com/dotnet/sdk:8.0 bash -c "cd /code;
dotnet build;
dotnet tool install -g ilspycmd;
DOTNET_ROLL_FORWARD=LatestMajor /root/.dotnet/tools/ilspycmd -il /code/bin/Debug/net8.0/itf.dll > 8.il
"
This required a minor change in js-snackbar lib included in the next commit
- Target net8.0
- Reference Mono.Cecil 0.11.5
@adrianoc adrianoc merged commit c8fa196 into main Feb 2, 2024
2 of 4 checks passed
@adrianoc adrianoc deleted the staging branch February 2, 2024 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant