Skip to content

Commit

Permalink
removes non relevant TODO (#303)
Browse files Browse the repository at this point in the history
TODO was questioning whether it would make sense to register a variable definition; it may or may not
improve the generated code quality but the method in question is only being used to handle events
add/remove methods so it does not worth investigating it.
  • Loading branch information
adrianoc committed Oct 18, 2024
1 parent f431936 commit 801cdad
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion Cecilifier.Core/Misc/Utils.cs
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ public static string MakeGenericTypeIfAppropriate(IVisitorContext context, ISymb
if (!(memberSymbol.ContainingSymbol is INamedTypeSymbol ts) || !ts.IsGenericType || !memberSymbol.IsDefinedInCurrentAssembly(context))
return backingFieldVar;

//TODO: Register the following variable?
var genTypeVar = context.Naming.GenericInstance(memberSymbol);
context.WriteCecilExpression($"var {genTypeVar} = {memberDeclaringTypeVar}.MakeGenericInstanceType({memberDeclaringTypeVar}.GenericParameters.ToArray());");
context.WriteNewLine();
Expand Down

0 comments on commit 801cdad

Please sign in to comment.