report violations of 'EnsureNotNull()' as 'NullReferenceException' in…

…stead of 'NotSupportedException'
adrianoc · Apr 3, 2024 · 6b09000 · 6b09000
1 parent 55c77f3
commit 6b09000
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/Cecilifier.Core/Extensions/ISymbolExtensions.cs b/Cecilifier.Core/Extensions/ISymbolExtensions.cs
@@ -1,6 +1,7 @@
 using System;
 using System.Diagnostics.CodeAnalysis;
 using System.Linq;
+using System.Runtime.CompilerServices;
 using Cecilifier.Core.AST;
 using Cecilifier.Core.Misc;
 using Cecilifier.Core.Naming;
@@ -80,10 +81,10 @@ public static bool IsByRef(this ISymbol symbol) =>
             };
 
         [return: NotNull]
-        public static T EnsureNotNull<T>([NotNullIfNotNull("symbol")] this T symbol) where T : ISymbol
+        public static T EnsureNotNull<T>([NotNullIfNotNull("symbol")] this T symbol, [CallerArgumentExpression(nameof(symbol))] string expression = null) where T : ISymbol
         {
             if (symbol == null)
-                throw new System.NotSupportedException("");
+                throw new NullReferenceException($"Expression '{expression}' is expected to not be null.");
 
             return symbol;
         }