Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This library has a lot of dependencies for a library, several of which seem unnecessary.
Description
All applications depending on this library will transitively inherit all of its dependencies. The more libraries, the bigger the risk of conflicts, and also the bigger the potential attack surface (e.g. take-overs or sneaky PRs).
We use Vonage for its services, but we don't want to inherit random dependencies if we can avoid it. Especially small "unknown" ones.
I removed/replaced three libraries:
Epoch.net
- easily replaced byDateTimeOffset.UtcNow.ToUnixTimeSeconds()
Yoh.Text.Json.NamingPolicies
- does not seem to be in useHandy.DotNETCore-Compatibility.ColorTranslations
- i inlined the codeHow Has This Been Tested?
The test suite passes in both NET 6 and NET 8.