fix(1-3363): frontend flag type should not return truthy for variant #9293
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Skipped Deployment
|
Dependency Review✅ No vulnerabilities or license issues or OpenSSF Scorecard issues found.OpenSSF Scorecard
Scanned Files |
| export const useUiFlag = <K extends keyof flags>(flag: K): boolean => { | ||
| const { uiConfig } = useUiConfig(); | ||
| const value = uiConfig?.flags?.[flag]; | ||
| if (typeof value === 'boolean') { | ||
| return value; | ||
| } else if (typeof value !== 'undefined') { | ||
| console.error(`Flag ${flag} does not return a boolean.`); | ||
| } | ||
|
|
||
| return uiConfig?.flags?.[flag] || false; | ||
| return false; |
There was a problem hiding this comment.
While I think this is fine in theory, I'm not confident about changing it now because we have places where we depend on the contents. Yeh, ts found the one in feedback component, but I don't really trust it to monitor everywhere. I don't see what we gain by changing this function right now. I'd rather look at other options too before changing this one.
There was a problem hiding this comment.
It's about 60 places, I can check it manually
There was a problem hiding this comment.
I don't know. That's a lot of stuff to do manually. It feels like a high risk, low reward move at this point. Lemme have a think about this. Let's continue the discussion tomorrow?
About the changes
Prevent issues with disabled variants resolving as truthy in frontend.