Extract RubyFileChangeHandler
#3225
Draft
+180
−150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
andyw8
commented
Feb 21, 2025
|
|
||
| assert_raises(Timeout::Error) do | ||
| Timeout.timeout(0.5) do | ||
| notification = find_message(RubyLsp::Notification, "window/logMessage") |
There was a problem hiding this comment.
(this test currently fails because find_message is not defined here)
andyw8
commented
Feb 21, 2025
| @@ -43,6 +43,7 @@ | |||
| require "ruby_lsp/rbs_document" | |||
| require "ruby_lsp/store" | |||
| require "ruby_lsp/addon" | |||
| require "ruby_lsp/file_change_handlers/ruby" | |||
There was a problem hiding this comment.
(I put this in a namespace since we may want to extract handlers for other kinds kinds of files, e.g. RuboCop config).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of #3174 we need to change the file watching behaviour to monitor changes to test files. Since
server.rbis very large (> 1400 lines), I am hesitant to add the behaviour there. I'm considering extracting this aspect out into its own class before adding the new behaviour.