Migrate to RBS signatures supported by Sorbet #3222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
How to use the Graphite Merge QueueAdd the label graphite-merge to this PR to add it to the merge queue. You must have a Graphite account in order to use the merge queue. Sign up using this link. An organization admin has enabled the Graphite Merge Queue in this repository. Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue. |
Morriar
commented
Feb 20, 2025
| @@ -87,7 +94,3 @@ Layout/ClassStructure: | |||
| - include | |||
| - prepend | |||
| - extend | |||
|
|
|||
| Layout/LeadingCommentSpace: | |||
There was a problem hiding this comment.
Just reordering by alphabetical order
Morriar
commented
Feb 20, 2025
| @@ -87,7 +94,3 @@ Layout/ClassStructure: | |||
| - include | |||
| - prepend | |||
| - extend | |||
|
|
|||
| Layout/LeadingCommentSpace: | |||
| Enabled: true | |||
There was a problem hiding this comment.
It's already enabled by default
Signed-off-by: Alexandre Terrasa <[email protected]>
Signed-off-by: Alexandre Terrasa <[email protected]>
Using `spoom srb sigs translate` Signed-off-by: Alexandre Terrasa <[email protected]>
Morriar
changed the title
Morriar
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PRs bump our Sorbet version to v0.5.11842 so we can start using RBS comment signatures instead of the
sig{}syntax 🎉I migrated all the signatures using
spoom srb sigs translate.Note that for the moment we're not translating signatures that contain
abstract.