Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Render TrendIndicator in tooltips #1809

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

envex
Copy link
Collaborator

@envex envex commented Feb 20, 2025

What does this implement/fix?

Adds the ability to render a TrendIndicator along side a data point in the tooltips. This should allow us to remove the AnalyticsTooltip need in analytics-ui-components and we can rely on using only the PV tooltip rendering.

What do the changes look like?

image

Storybook link

https://6062ad4a2d14cd0021539c1b-iwwvtwfwgf.chromatic.com/?path=/story/polaris-viz-charts-linechart--default

Before merging

  • Check your changes on a variety of browsers and devices.

  • Update the Changelog's Unreleased section with your changes.

  • Update relevant documentation, tests, and Storybook.

  • Make sure you're exporting any new shared Components, Types and Utilities from the top level index file of the package

@envex envex changed the title Envex/tooltip trend indicator ender TrendIndicator in tooltips Feb 20, 2025
@envex envex changed the title ender TrendIndicator in tooltips Render TrendIndicator in tooltips Feb 20, 2025
@envex envex force-pushed the envex/tooltip-trend-indicator branch 2 times, most recently from c32c988 to b9325b0 Compare February 20, 2025 15:27
@envex envex marked this pull request as ready for review February 20, 2025 15:27
Copy link

github-actions bot commented Feb 20, 2025

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
polaris-viz-core-cjs 61.53 KB (0%) 1.3 s (0%) 962 ms (+7.04% 🔺) 2.2 s
polaris-viz-cjs 231.52 KB (+0.16% 🔺) 4.7 s (+0.16% 🔺) 1.7 s (-16.98% 🔽) 6.3 s
polaris-viz-esm 187.74 KB (+0.34% 🔺) 3.8 s (+0.34% 🔺) 1.6 s (-13.13% 🔽) 5.3 s
polaris-viz-css 5.98 KB (+0.46% 🔺) 120 ms (+0.46% 🔺) 274 ms (+23.38% 🔺) 394 ms
polaris-viz-esnext 194.53 KB (+0.06% 🔺) 3.9 s (+0.06% 🔺) 1.2 s (-31.97% 🔽) 5 s

@envex envex force-pushed the envex/tooltip-trend-indicator branch from b9325b0 to 458212d Compare February 20, 2025 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant