Fixed shopify theme dev to avoid emitting full page reload events when files are updated successfully
#5448
+138
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hen files are updated successfully, preventing conflicts with hot-reloading
Coverage report
Show files with reduced coverage 🔻
Test suite run success2066 tests passing in 922 suites. Report generated by 🧪jest coverage report action from d361f3a |
frandiox
approved these changes
Feb 21, 2025
| throw new Error(errors.join('\n')) | ||
| } | ||
|
|
||
| if (uploadErrors.delete(fileKey)) { |
There was a problem hiding this comment.
TIL this returns a boolean
EvilGenius13
approved these changes
Feb 21, 2025
jamesmengo
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Fixes https://github.com/Shopify/developer-tools-team/issues/583
WHAT is this pull request doing?
This PR updates the error overlay to only reload the page when there was an error being loaded.
How to test your changes?
shopify theme devPost-release steps
N/A
Measuring impact
How do we know this change was effective? Please choose one:
Checklist