Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SHOPIFY_CLI_NEVER_USE_APP_MANAGEMENT_API #5447

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Conversation

shauns
Copy link
Contributor

@shauns shauns commented Feb 21, 2025

Internal

Copy link
Contributor Author

shauns commented Feb 21, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link
Contributor Author

shauns commented Feb 21, 2025

/snapit

Copy link
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/private/node/constants.d.ts
@@ -32,6 +32,7 @@ export declare const environmentVariables: {
     themeKitAccessDomain: string;
     json: string;
     neverUsePartnersApi: string;
+    neverUseAppManagementApi: string;
 };
 export declare const defaultThemeKitAccessDomain = "theme-kit-access.shopifyapps.com";
 export declare const systemEnvironmentVariables: {

Copy link
Contributor

🫰✨ Thanks @shauns! Your snapshot has been published to npm.

Test the snapshot by installing your package globally:

pnpm i -g @shopify/[email protected]

Tip

If you get an ETARGET error, install it with NPM and the flag --@shopify:registry=https://registry.npmjs.org

Caution

After installing, validate the version by running just shopify in your terminal.
If the versions don't match, you might have multiple global instances installed.
Use which shopify to find out which one you are running and uninstall it.

Copy link
Contributor

Coverage report

St.
Category Percentage Covered / Total
🟡 Statements
75.73% (+0.01% 🔼)
9073/11980
🟡 Branches
71.02% (+0.1% 🔼)
4428/6235
🟡 Functions
75.37% (-0.06% 🔻)
2371/3146
🟡 Lines
76.25% (-0.02% 🔻)
8568/11237
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🟡
... / dev.ts
78% (-2.77% 🔻)
65.22% (-1.45% 🔻)
77.78% (-4.58% 🔻)
75% (-3.26% 🔻)
🟢
... / select-store.ts
83.67% (-0.64% 🔻)
81.82% (-1.52% 🔻)
71.43%
84.78% (-2.45% 🔻)
🟢
... / app-event-watcher.ts
95.18% (-1.2% 🔻)
86.49% (-2.7% 🔻)
95.45% 100%
🔴
... / app-management-client.ts
35.45% (-0.24% 🔻)
27.66% 35.05%
34.41% (-0.26% 🔻)
🔴
... / partners-client.ts
26.62% (-0.52% 🔻)
37.5% 17.54%
26.32% (-0.55% 🔻)
🔴
... / graphql.ts
5.88% (-60.78% 🔻)
0% (-55.56% 🔻)
25% (-41.67% 🔻)
5.88% (-59.83% 🔻)

Test suite run success

2056 tests passing in 920 suites.

Report generated by 🧪jest coverage report action from 0da0052

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant