[Themes] Skip proxy fallback for known rendering requests #5445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
Coverage report
Show files with reduced coverage 🔻
Test suite run success2066 tests passing in 922 suites. Report generated by 🧪jest coverage report action from 0d1d9ce |
karreiro
approved these changes
Feb 21, 2025
There was a problem hiding this comment.
Thank you for this PR, @frandiox! It looks good to me and works as expected as well.
I've shared a minor suggestion regarding H3 events, but it is optional (I would love to hear your thoughts on that tho).
Thanks again for this PR!
| * Detects routes and params that indicate this request should be handled by SFR. | ||
| */ | ||
| function isKnownRenderingRequest(event: H3Event) { | ||
| const searchParams = new URLSearchParams(event.path.split('?')[1]) |
There was a problem hiding this comment.
I noticed this logic in other areas. I wonder if it might be nice to decorate™️ events to have this in a single place, with something like this:
event = devServer(event)
event.queryParams
event.pathname
EvilGenius13
approved these changes
Feb 21, 2025
jamesmengo
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Requests using Section Rendering API and such don't need the proxy fallback since we are sure they are supposed to go to SFR. This is a quick fix to make logs easier for an issue that @jamesmengo is debugging.
WHAT is this pull request doing?
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist