[ShopifyVM] cli use new dev dash endpoints for polling #5443
+137
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses: https://github.com/Shopify/shopify-functions/issues/606
WHY are these changes introduced?
Currently, app logs are fetched directly from Partners API. We need to use the new core endpoints set out in this branch.
Current Implementation:
Subscribe to Logs
https://${partnersFqdn}/api/cli/graphql
AppLogsSubscribeMutation
to get JWT tokenapp-management-client.ts
Poll Logs
https://${partnersFqdn}/app_logs/poll
utils.ts
WHAT is this pull request doing?
Updated the
AppManagementClient
to implement thesubscribeToAppLogs
method.developerPlatformClient
interface - we need access toapiKey
organizationId
,appId
for request to dev dash (these are not required for partners requests).targetSchemaDefinition
fieldsUpdated
PollAppLogs
How to test your changes?
Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist