Update mutation variables for AppCreate #5436
Open
+46
−45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report
Show files with reduced coverage 🔻
Test suite run success2065 tests passing in 922 suites. Report generated by 🧪jest coverage report action from 506e356 |
dmerand
force-pushed
the
dlm-app-create-mutation-variables
branch
from
4ccd141 to
c3a6297
Compare
|
We detected some changes at packages/*/src and there are no updates in the .changeset. |
dmerand
force-pushed
the
dlm-app-create-mutation-variables
branch
from
c3a6297 to
d45a6ab
Compare
dmerand
force-pushed
the
dlm-app-create-mutation-variables
branch
from
d45a6ab to
506e356
Compare
isaacroldan
approved these changes
Feb 21, 2025
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per https://github.com/Shopify/develop-app-inner-loop/issues/2530, update the
AppCreatemutation to use app manifests via theAppVersionInputobject.WHY are these changes introduced?
We updated the API shape + need the CLI to follow suit.
WHAT is this pull request doing?
Changing the
AppCreatemutation to useAppVersionInputinstead ofAppSourceInput. Because the GraphQL interface specifies a very generic JSON type, Added theAppVersionSourceinterface to help ensure we're using the right data shape.The alternative to
AppVersionSourcewould be for the API to somehow advertise the expected shape of theAppSourcemanifest. Since this shape isn't expected to evolve over time, I feel that it's OK to hard-code into both sides of the API (asAppVersionSourcein the CLI, and asSourceinshop/world). But I could be convinced otherwise.How to test your changes?
If you can create an app, it's working:
p shopify app initand then create a new app.Post-release steps
Measuring impact
How do we know this change was effective? Please choose one:
Checklist