Validate the backend in params #141
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip profiling if the backend is not supported
Sam-Killgallon
force-pushed
the
validate-backend-params
branch
from
4114413 to
d402d3a
Compare
bmansoob
reviewed
Oct 18, 2024
| @@ -50,6 +51,12 @@ def valid? | |||
| true | |||
| end | |||
|
|
|||
| def valid_backend? | |||
| return true if AppProfiler::Backend::StackprofBackend.name == backend | |||
There was a problem hiding this comment.
I know it achieves the same outcome and it is probably a matter of personal preference - but I would rather get rid of AppProfiler::Backend::StackprofBackend.name == backend and have something which checks if backend is one of the two. We can define a constant AVAILABLE_BACKENDS
bmansoob
reviewed
Oct 18, 2024
| @@ -29,6 +29,13 @@ class RequestParametersTest < TestCase | |||
| end | |||
| end | |||
|
|
|||
| test "#valid? returns false when backend is not supported" do | |||
| AppProfiler.logger.expects(:info).with { |value| value =~ /unsupported backend='not-a-real-backend'/ } | |||
There was a problem hiding this comment.
Maybe we do not need check the logs and valid? is sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly handle the case when the backend provided by params is not supported by AppProfiler