Upgrade all crates to the 2024 edition, bump MSRV to 1.85 #1759
+1,055
−778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarcieri
reviewed
Feb 21, 2025
tarcieri
approved these changes
Feb 21, 2025
newpavlov
force-pushed
the
edition_upgrade
branch
from
569cc62 to
8a04557
Compare
newpavlov
force-pushed
the
edition_upgrade
branch
from
e259ec6 to
3fd00fd
Compare
newpavlov
commented
Feb 22, 2025
Cargo.toml
Outdated
| crypto-common = { path = "./crypto-common" } | ||
| digest = { path = "./digest" } | ||
| signature = { path = "./signature" } | ||
| exclude = ["elliptic-curve"] |
There was a problem hiding this comment.
elliptic-curve is temporarily excluded from the workspace because it can not be migrated to hybrid-array v0.3 yet, but it pulls block-buffer v0.11.0-rc.4 in tests, which depends on hybrid-array v0.3. It causes breakage, so we have to manually downgrade block-buffer to v0.11.0-rc.3.
UPD: Same with signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1717