Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

elliptic-curve: bump rand_core to 0.9.0 #1751

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

baloo
Copy link
Member

@baloo baloo commented Feb 14, 2025

@newpavlov
Copy link
Member

newpavlov commented Feb 14, 2025

@tarcieri
BTW how important is dependency on ff and group crates for elliptic-curve and its downstream users?

@tarcieri
Copy link
Member

@newpavlov extremely. They provide the traits that generic protocol implementations such as the ecdsa crate are written in terms of

@newpavlov
Copy link
Member

newpavlov commented Feb 14, 2025

I mean, why can't we define those traits in our crates? Judging by the commit history, development is not particularly active for both crates. And it seems a bit strange to unconditionally depend on third-party crates for such important piece of functionality.

@tarcieri
Copy link
Member

I would rather work with @str4d first than try to vendor ff and group into elliptic-curve.

Among other problems there are already existing forks of those crates in e.g. ark-ff and if anything I would like to see those forks resolved so there actually are a common set of traits for the whole Rust elliptic curve ecosystem.

@newpavlov
Copy link
Member

Maybe we should ask zkcrypto developers whether they would be open to transferring those crates under our umbrella?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants