-
Notifications
You must be signed in to change notification settings - Fork 11.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: check if new LDAP users will exceed the license #35244
base: develop
Are you sure you want to change the base?
Conversation
Looks like this PR is not ready to merge, because of the following issues:
Please fix the issues and try again If you have any trouble, please check the PR guidelines |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #35244 +/- ##
========================================
Coverage 59.45% 59.45%
========================================
Files 2828 2828
Lines 68159 68159
Branches 15124 15124
========================================
Hits 40521 40521
Misses 24982 24982
Partials 2656 2656
Flags with carried forward coverage won't be shown. Click here to find out more. |
🦋 Changeset detectedLatest commit: 84446c1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 35 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
I can't write tests for this one. E2E is impossible because of the LDAP, and unit testing is almost insane, considering how much I would need to mock and how artificial the test would be. |
Proposed changes (including videos or screenshots)
Check the license before inserting new users on the LDAP Sync. (It will continue to update existing users)
Issue(s)
CORE-990
Steps to test or reproduce
Further comments