feat(Teckie): add Teckie support #9280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kuriel23
approved these changes
Feb 13, 2025
Kuriel23
suggested changes
Feb 13, 2025
now a 560x560
darkvillager2
suggested changes
Feb 16, 2025
There was a problem hiding this comment.
For English see below.
---------
Hallo Maatje,
Bedankt voor je PR. Ik heb wat opmerkingen/vragen hierover. Graag de verzochte wijzigingen maken.
Mocht je vragen hebben, stel ze in dit PR of op discord (@dark_ville)
Groet,
Mede Kaaskop
Dark
-----------
Hello Mate,
Thanks for your PR, i have some questions/notes about it. Please make the changes as requested.
If you have any questions feel free to ask in this pr or on discord (@dark_ville)
~Dark
|
Hello from mobile, I've been and still am sick with the flu. Will make changes once I'm better. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: bakzkndd <[email protected]>
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: bakzkndd <[email protected]>
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: bakzkndd <[email protected]>
Co-authored-by: github plz bring back DarkVIllager <[email protected]> Signed-off-by: bakzkndd <[email protected]>
realized that all the cases could get their info from the same place, so to reduce double code just moved it to the bottom
|
oh no I forgot the good commit names |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for Teckie. A dutch computer sales, repair and support company. Has support for all pages. Checkout page just shows the status for the base url to protect privacy.
Sidenote: didn't run
yarn formatbut insteadnpm run lint:fix.yarn formatdidn't work for me and was told in the Discord server to usenpm run lint:fixinstead. Not sure if the PR template needs updating.Acknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected
Example 1:  Example 2:
