DRAFT: perl.h - add nice aliases for PERL_DEB() and PERL_DEB2() #22986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
demerphq
force-pushed
the
yves/add_nicer_PERL_DEB_aliases
branch
2 times, most recently
from
37c9c9a to
26f43ba
Compare
|
Looks good to me, and the names are clearer than the originals. |
This patch renames PERL_DEB() to PERL_IF_DEBUGGING() and renames PERL_DEB2() to PERL_IF_DEBUGGING_ELSE(). It also documents them, along with PERL_DEBUG() and DEBUG_r() and friends. I have switched the existing PERL_DEB() or PERL_DEB2() calls to use the new names, but kept aliases for the old names just in case they are used out in the wild (eg CPAN). Thanks to mauke for the name suggestions!
demerphq
force-pushed
the
yves/add_nicer_PERL_DEB_aliases
branch
from
26f43ba to
0614b1e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch adds PERL_IF_DEBUGGING() as an alias for PERL_DEB() and and adds PERL_IF_DEBUGGING_ELSE() as an alias for PERL_DEB2(). (Thanks to mauke for the names.) It also documents them, along with PERL_DEBUG() and DEBUG_r() and friends.
Currently I have not switched the existing PERL_DEB() or PERL_DEB2() calls to use the new names. I wanted to get feedback on this first.