eas-cli: fix most functionalities missing and dangling symlink #382261
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(and if you keep the hooks, you don't need to change the phase from |
|
@donovanglover Thanks for the feedback, and I applied the changes. In this case replacing yarnInstallHook fixed both issues simultaneously, so I have it as one commit addressing both issues. |
eclairevoyant
suggested changes
Feb 19, 2025
| jq '. + {version: "${finalAttrs.version}"}' package.json > package.json.tmp | ||
| mv package.json.tmp package.json | ||
| # yarnInstallHook strips out build outputs within packages/eas-cli resulting in most commands missing from eas-cli. | ||
| installPhase = '' |
There was a problem hiding this comment.
Suggested change
| installPhase = '' | |
| installPhase = '' | |
| runHook preInstall | |
| installPhase = '' | ||
| mkdir -p $out/lib/node_modules/eas-cli-root | ||
| yarn install --immutable --immutable-cache --offline --non-interactive --production --frozen-lockfile | ||
| cp -r . $out/lib/node_modules/eas-cli-root | ||
| ''; |
There was a problem hiding this comment.
Suggested change
| ''; | |
| runHook preInstall | |
| ''; |
| nodejs | ||
| patchelf |
There was a problem hiding this comment.
I don't see the purpose of this line, given that stdenv already provides patchelf
Suggested change
| patchelf |
and I don't see it used
There was a problem hiding this comment.
/nix/store/h9lc1dpi14z7is86ffhl3ld569138595-audit-tmpdir.sh: line 23: patchelf: command not found
I get this unless I explicitly put patchelf in buildInput. I'm on nix-darwin so maybe thats why?
eas-cli: add preInstall and postInstall hooks eas-cli: use postFixup instead of postInstall
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #381256 and #382259
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.