ember-language-server: init at 2.30.5

[Thao-Tran]

Things done

• Built on platform(s)
  • x86_64-linux
  • aarch64-linux
  • x86_64-darwin
  • aarch64-darwin
• For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • sandbox = relaxed
  • sandbox = true
• Tested, as applicable:
  • NixOS test(s) (look inside nixos/tests)
  • and/or package tests
  • or, for functions and "core" functionality, tests in lib/tests or pkgs/test
  • made sure NixOS tests are linked to the relevant packages
• Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
• Tested basic functionality of all binary files (usually in ./result/bin/)
• 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
  • (Package updates) Added a release notes entry if the change is major or breaking
  • (Module updates) Added a release notes entry if the change is significant
  • (Module addition) Added a release notes entry if adding a new NixOS module
• Fits CONTRIBUTING.md.

---

Add a 👍 reaction to pull requests you find important.

[Tert0]

Some suggestions:

diff --git a/pkgs/by-name/em/ember-language-server/package.nix b/pkgs/by-name/em/ember-language-server/package.nix
index e6306e56ec2a..9863dbfbbff1 100644
--- a/pkgs/by-name/em/ember-language-server/package.nix
+++ b/pkgs/by-name/em/ember-language-server/package.nix
@@ -1,7 +1,6 @@
 {
   lib,
   stdenv,
-  mkYarnPackage,
   fetchFromGitHub,
   fetchYarnDeps,
   nodejs,
@@ -10,19 +9,19 @@
   yarnBuildHook,
 }:
 
-stdenv.mkDerivation rec {
+stdenv.mkDerivation (finalAttrs: {
   pname = "ember-language-server";
   version = "2.30.5";
 
   src = fetchFromGitHub {
     owner = "ember-tooling";
-    repo = pname;
-    tag = "v${version}";
+    repo = "ember-language-server";
+    tag = "v${finalAttrs.version}";
     hash = "sha256-/6j71pBmZor7C1u9BkptwwQonh6ZWoLmMDCMOGCpMik=";
   };
 
   yarnOfflineCache = fetchYarnDeps {
-    yarnLock = src + "/yarn.lock";
+    yarnLock = "${finalAttrs.src}/yarn.lock";
     hash = "sha256-vWCG+FDf6XTNrgqOQGMnE6xNZ5A8PU5DA+FcTLLurIg=";
   };
 
@@ -40,11 +39,12 @@ stdenv.mkDerivation rec {
     ln -s $out/bin/@ember-tooling/ember-language-server $out/bin/ember-language-server
   '';
 
-  meta = with lib; {
+  meta = {
     description = "Language Server Protocol implementation for Ember.js projects";
     homepage = "https://github.com/ember-tooling/ember-language-server";
-    license = licenses.mit;
-    maintainers = with maintainers; [ ThaoTranLePhuong ];
+    changelog = "https://github.com/ember-tooling/ember-language-server/blob/master/CHANGELOG.md";
+    license = lib.licenses.mit;
+    maintainers = with lib.maintainers; [ ThaoTranLePhuong ];
     mainProgram = "ember-language-server";
   };
-}
+})

[Thao-Tran]

@Tert0 Just a small question about this suggested change:

-    repo = pname;
+    repo = "ember-language-server";

Is there a reason why repeating the package name is preferred over using the variable?

[Tert0]

Is there a reason why repeating the package name is preferred over using the variable?

Yes, see #277994

[Tert0]

Please reorder and squash the commits into this (in this order):

• maintainers: add ThaoTranLePhuong
• ember-language-server: init at 2.30.5

git rebase -i can be used to do that

[Thao-Tran]

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 382209

Logs: https://github.com/Thao-Tran/nixpkgs-review-gha/actions/runs/13357426091

---

x86_64-linux

✅ 1 package built:

• ember-language-server

---

aarch64-linux

✅ 1 package built:

• ember-language-server

---

x86_64-darwin

✅ 1 package built:

• ember-language-server

---

aarch64-darwin

✅ 1 package built:

• ember-language-server

[ethancedwards8]

LGTM.

[donovanglover]

Grats on your first contribution to nixpkgs!