Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport release-24.11] linux_xanmod, linux_xanmod_latest: 2025-02-08 updates #381721

Merged
merged 3 commits into from
Feb 13, 2025

Conversation

eljamm
Copy link
Contributor

@eljamm eljamm commented Feb 13, 2025

Manual backport of #373041 and #380228

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 6.topic: kernel The Linux kernel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501+ 10.rebuild-linux: 501-1000 labels Feb 13, 2025
@Shawn8901 Shawn8901 removed their request for review February 13, 2025 12:04
@Shawn8901
Copy link
Contributor

I am no longer using xanmod, so removing the request

@eljamm
Copy link
Contributor Author

eljamm commented Feb 13, 2025

I am no longer using xanmod, so removing the request

@Shawn8901 I'm sorry for that. I think you need to backport your removal PR to stable so you wouldn't get pinged in the future.

On that note, I really hope that you consider becoming a maintainer again. I understand your frustration with how things were before, but there are probably better solutions that we can come up with as a team. Whatever you decide to do, though, I thank you a lot, both for maintaining xanmod and for welcoming me as a maintainer.

@Shawn8901
Copy link
Contributor

Shawn8901 commented Feb 13, 2025

@Shawn8901 I'm sorry for that. I think you need to backport your removal PR to stable so you wouldn't get pinged in the future

I know, I already added the label to the old PR, just waiting for someone to merge it ( #381732 )

About the maintainership: I am (sadly) not planning to move back in using xanmod, if so I would more build a downstream flake and maybe work on making a better experience for downstream kernels.
That is IMHO the better long term solution for nixpks.

@Atemu Atemu merged commit 85e03dd into NixOS:release-24.11 Feb 13, 2025
27 of 28 checks passed
@eljamm eljamm deleted the backport-380228-to-release-24.11 branch February 13, 2025 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: kernel The Linux kernel 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants