nixos/nginx: remove recommendedZstdSettings, add experimental option #381678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
6.topic: nixos
fpletz
force-pushed
the
nixos/nginx-experimental-zstd-settings
branch
from
8b1ca4f to
f001242
Compare
github-actions
bot
added
10.rebuild-darwin: 0
This was referenced Feb 13, 2025
The zstd nginx module has known bugs and upstream is currently not maintained. We should not recommend a buggy module and configuration to our users since we are not maintaining the module either.
fpletz
force-pushed
the
nixos/nginx-experimental-zstd-settings
branch
from
f001242 to
77270af
Compare
ambroisie
added a commit
to ambroisie/nix-config
that referenced
this pull request
Feb 13, 2025
The zstd module is unmaintained and buggy, remove it preventively. The option itself will probably be removed soon [1]. [1]: NixOS/nixpkgs#381678
Co-authored-by: Sandro <[email protected]>
Co-authored-by: Sandro <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zstd nginx module has known bugs and upstream is currently not maintained. We should not recommend a buggy module and configuration to our users since we are not maintaining the module either.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.