Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sm64coopdx: 1.0.4 -> 1.1.1 #381623

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shelvacu
Copy link
Contributor

No major changes. Changelogs: https://github.com/coop-deluxe/sm64coopdx/releases/tag/v1.1 https://github.com/coop-deluxe/sm64coopdx/releases/tag/v1.1.1

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
  • No applicable tests
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
    • For some reason nixpkgs-review detected other packages and those failed to build, but sm64coopdx buildx fine.
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • No release notes, change is not major or breaking
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@keenanweaver keenanweaver added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants