Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lerna: repackage with buildNpmPackage #381617

Merged
merged 2 commits into from
Feb 17, 2025

Conversation

Thao-Tran
Copy link
Contributor

@Thao-Tran Thao-Tran commented Feb 13, 2025

Repackage nodePackages.lerna to be built using buildNpmPackage and create variants for lerna_6 and lerna_8.

Refs: #229475

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately needed to include the package-lock files because the one to the GitHub repo isn't compatible with cached installs.

@Thao-Tran Thao-Tran force-pushed the repackage-lerna branch 3 times, most recently from ce694d5 to 2cff95c Compare February 16, 2025 17:48
* Include lerna_6 and lerna_8 variants
@SuperSandro2000
Copy link
Member

Since we now commit the lockfile, do we really need to keep 2 versions? is version 8 not enough?

@Thao-Tran
Copy link
Contributor Author

@SuperSandro2000 I added a v6 variant because it's the version that I need to use for my company's codebase since v8 introduced a lot of breaking changes, but I understand if having two lockfiles is too much. Let me know if you have a strong opposition to maintaining both versions and I can just keep it in my nixpkgs fork instead.

Hmm I am wondering now though, would it be considered bad practice if I changed this to point to a personal fork of lerna that actually provides a proper lockfile for both versions, so we don't have to keep the lockfile in the nixpkgs VCS?

@SuperSandro2000
Copy link
Member

I am just going to assume that this is a general thing and we merge this for now :)

Hmm I am wondering now though, would it be considered bad practice if I changed this to point to a personal fork of lerna that actually provides a proper lockfile for both versions, so we don't have to keep the lockfile in the nixpkgs VCS?

That makes it harder for everyone to update.

@SuperSandro2000 SuperSandro2000 merged commit adaf770 into NixOS:master Feb 17, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: nodejs 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
Status: Re-packaged
Development

Successfully merging this pull request may close these issues.

3 participants