-
-
Notifications
You must be signed in to change notification settings - Fork 15k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lerna: repackage with buildNpmPackage #381617
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately needed to include the package-lock files because the one to the GitHub repo isn't compatible with cached installs.
ce694d5
to
2cff95c
Compare
2cff95c
to
53f57d2
Compare
* Include lerna_6 and lerna_8 variants
53f57d2
to
634383b
Compare
Since we now commit the lockfile, do we really need to keep 2 versions? is version 8 not enough? |
@SuperSandro2000 I added a v6 variant because it's the version that I need to use for my company's codebase since v8 introduced a lot of breaking changes, but I understand if having two lockfiles is too much. Let me know if you have a strong opposition to maintaining both versions and I can just keep it in my nixpkgs fork instead. Hmm I am wondering now though, would it be considered bad practice if I changed this to point to a personal fork of |
I am just going to assume that this is a general thing and we merge this for now :)
That makes it harder for everyone to update. |
Repackage
nodePackages.lerna
to be built usingbuildNpmPackage
and create variants forlerna_6
andlerna_8
.Refs: #229475
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.