Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sqlite: 3.48.0 -> 3.49.0 #381496

Open
wants to merge 1 commit into
base: staging
Choose a base branch
from
Open

sqlite: 3.48.0 -> 3.49.0 #381496

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Feb 12, 2025

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@aduh95
Copy link
Contributor Author

aduh95 commented Feb 12, 2025

Error: Unknown option --docdir 🤔 I don't see any related change in SQLite changelog

@K900
Copy link
Contributor

K900 commented Feb 12, 2025

CC @trofi

@trofi
Copy link
Contributor

trofi commented Feb 12, 2025

Yeah, that is the effect of:

Replace Autotools with Autosetup for the configure script used in the precompiled amalgamation tarball. The configure script for the canonical source code was changed to Autosetup in the previous (3.48.0) release. Only the main SQLite configure script in the amalgamation tarball is changed. The (deprecated) configuration script use by TEA subdirectory of the amalgamation tarball still relies on Autotools.

We'll need to remove a bunch of options that nixpkgs injects. In #380400 I removed vestigal --oldincludedir. More ubiquitous ones will need to be handled differently (most likely we would need to use setOutputFlags = false; and pass the subset that sqlite requires).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants