Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

redpanda-connect: init at 4.47.1 #381463

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

artemklevtsov
Copy link

Short description: stream processor with many connectors written in Go.

Homepage: https://www.redpanda.com/connect

This package is benthos package clone. Fix #325717

Not sure about license.

@sagikazarmark please review it.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@sagikazarmark
Copy link
Member

This is problematic because that repo contains code under multiple licenses, as explained here.

Although they don't go into details, the list of "community" (licensed under Apache-2.0) and "enterprise" (licensed under RCL - Redpanda Community Licence) is available here.

I don't think the package in NixOS should contain the enterprise plugins to be honest, because they are not Open Source.

I would, however, probably build the module in a way that allows users to turn on those plugins in their builds. I would probably expose a module argument that controls whether those plugins are included (by default false).

On the implementation side, a patch removing those plugins from the import section would probably be enough.

An alternative is maintaining a flake. I would probably reach out to Redpanda and ask them if they would be willing to host one.

@artemklevtsov
Copy link
Author

Notes by benthos author about license policies: redpanda-data/connect#2621 (comment)

@artemklevtsov
Copy link
Author

artemklevtsov commented Feb 15, 2025

Seems cmd/redpanda-connect-community/main.go provides open source build with Apache License.
Note: rpk package already exists in the nixpkgs with bsl11.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Package request: redpanda-connect
3 participants