Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.lzextras: init at 0.1.17 #381371

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

BirdeeHub
Copy link
Contributor

@BirdeeHub BirdeeHub commented Feb 12, 2025

extensions repository for https://github.com/BirdeeHub/lze

@GaetanLepage the new plugin is here! All features are tested and it has a reasonable enough readme now to be committed here, where people won't see the readme anyway.

  meta = {
    homepage = "https://github.com/BirdeeHub/lzextras";
    description = "A collection of utilities and handlers for BirdeeHub/lze";
    maintainers = with lib.maintainers; [ birdee ];
    license.fullName = "GPL-2+";
  };

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@BirdeeHub
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381371


x86_64-linux

✅ 7 packages built:
  • lua51Packages.lzextras
  • luaPackages.lzextras (lua52Packages.lzextras)
  • lua53Packages.lzextras
  • lua54Packages.lzextras
  • luajitPackages.lzextras
  • vimPlugins.lzextras
  • vimPluginsUpdater

@BirdeeHub
Copy link
Contributor Author

whoa that pinged a lot of people this time

@GaetanLepage
Copy link
Contributor

whoa that pinged a lot of people this time

This is normal, we are all members of the Neovim team on nixpkgs.

@BirdeeHub
Copy link
Contributor Author

I get that but it doesn't do it for updates so I was surprised still. Anyway, is there any problems with the PR I should fix?

@GaetanLepage
Copy link
Contributor

I get that but it doesn't do it for updates so I was surprised still. Anyway, is there any problems with the PR I should fix?

Because lua package updates do not change any files under pkgs/applications/editors/vim/.

@GaetanLepage
Copy link
Contributor

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381371


x86_64-linux

✅ 7 packages built:
  • lua51Packages.lzextras
  • luaPackages.lzextras (lua52Packages.lzextras)
  • lua53Packages.lzextras
  • lua54Packages.lzextras
  • luajitPackages.lzextras
  • vimPlugins.lzextras
  • vimPluginsUpdater

aarch64-linux

✅ 7 packages built:
  • lua51Packages.lzextras
  • luaPackages.lzextras (lua52Packages.lzextras)
  • lua53Packages.lzextras
  • lua54Packages.lzextras
  • luajitPackages.lzextras
  • vimPlugins.lzextras
  • vimPluginsUpdater

x86_64-darwin

✅ 7 packages built:
  • lua51Packages.lzextras
  • luaPackages.lzextras (lua52Packages.lzextras)
  • lua53Packages.lzextras
  • lua54Packages.lzextras
  • luajitPackages.lzextras
  • vimPlugins.lzextras
  • vimPluginsUpdater

aarch64-darwin

✅ 7 packages built:
  • lua51Packages.lzextras
  • luaPackages.lzextras (lua52Packages.lzextras)
  • lua53Packages.lzextras
  • lua54Packages.lzextras
  • luajitPackages.lzextras
  • vimPlugins.lzextras
  • vimPluginsUpdater

Copy link
Member

@PerchunPak PerchunPak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

blocked by #380691, please don't merge new plugins

@PerchunPak
Copy link
Member

PerchunPak commented Feb 12, 2025

though this plugin is cool, I definetly should switch away from lazynvim

@BirdeeHub
Copy link
Contributor Author

BirdeeHub commented Feb 12, 2025

does this mean I can run the nvim plugin updater without it crashing when you are done?! XD (JK sorta it only crashed on my old computer it works on this one, it also deletes some of the plugins though...)

But yeah exciting stuff, lockfile is better than generated nix expressions for this sort of thing. I didnt know progress was that far along on that

BirdeeHub pushed a commit to BirdeeHub/nixCats-nvim that referenced this pull request Feb 12, 2025
BirdeeHub pushed a commit to BirdeeHub/nixCats-nvim that referenced this pull request Feb 12, 2025
BirdeeHub pushed a commit to BirdeeHub/nixCats-nvim that referenced this pull request Feb 13, 2025
BirdeeHub pushed a commit to BirdeeHub/nixCats-nvim that referenced this pull request Feb 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants