apple-sdk_15: 15.0 -> 15.2; darwin.*: source release updates #381343
+92
−113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apple like to remove old minor releases of the SDK when bumping to a new one. Our current 15.0 SDK is already gone. Since these are all the last minor version of their major version, they’re probably not at risk of imminent deletion, but given their general practices it makes sense to guard against, especially as we can’t be sure ahead of time what the last minor version will be.
It seems like `unifdefall(1)` was omitted from this package previously; I’m not sure why.
This was unhappy about missing BPF `struct` stuff. I’m not sure why the private header thing was like that previously but it builds fine like this.
Apple removed the `spray.x` source and replaced it with vendored `rpcgen(1)` output for some reason. Not sure it’s worth trying to undo that.
emilazy
added
6.topic: darwin
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thankfully it is possible to save pages to the Wayback Machine again, and it works fine to archive the SDKs, so we shouldn’t run into any more bitrotting mishaps like #359460.
A few non‐trivial commits here that could use review; see the commit messages for details.
Things done
{apple-sdk_{11,12,13,14,15},darwin.{AvailabilityVersions,ICU,PowerManagement,copyfile,developer_cmds,diskdev_cmds,libffi,libiconv,libpcap,network_cmds,system_cmds,top}}nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.