flac: 1.4.3 -> 1.5.0; modernize derivation #381219
Conversation
| src = fetchFromGitHub { | ||
| owner = "xiph"; | ||
| repo = "flac"; | ||
| tag = finalAttrs.version; | ||
| hash = "sha256-B6XRai5UOAtY/7JXNbI3YuBgazi1Xd2ZOs6vvLq9LIs="; | ||
| }; |
There was a problem hiding this comment.
The release on GitHub is very recent, I expect https://xiph.org/flac/download.html will be updated as well with the new release later, so we can continue to take it from there.
There was a problem hiding this comment.
Let's not do that for two reasons:
- Github seems to be the primary place of the source code, so that is where it will be first and foremost
- I have yet to forget the xz incident and I hope you haven't either
pkgs/by-name/fl/flac/package.nix
Outdated
|
|
||
| CFLAGS = [ | ||
| "-O3" | ||
| "-funroll-loops" | ||
| ]; | ||
| CXXFLAGS = [ "-O3" ]; | ||
|
|
||
| # doCheck = true; # takes lots of time | ||
| doCheck = false; # takes lots of time |
There was a problem hiding this comment.
I don’t know why it ended up being commented, but if the tests were enabled previously, why disable them now?
pkgs/by-name/fl/flac/package.nix
Outdated
| bsd3 | ||
| fdl13Only | ||
| gpl2Only | ||
| lgpl21Only |
There was a problem hiding this comment.
In at least this file, it’s LGPL 2.1 or later.
pkgs/by-name/fl/flac/package.nix
Outdated
| license = with lib.licenses; [ | ||
| bsd3 | ||
| fdl13Only | ||
| gpl2Only |
There was a problem hiding this comment.
In at least this file, it’s GPL 2 or later.
| homepage = "https://xiph.org/flac/"; | ||
| description = "Library and tools for encoding and decoding the FLAC lossless audio file format"; | ||
| changelog = "https://xiph.org/flac/changelog.html"; |
There was a problem hiding this comment.
I expect the website will be updated for 1.5, if it’s not there in a few days we can ask on the mailing list what the plans are. (I haven’t seen an announcement there yet, so I suppose the release is still in progress.) I would keep the metadata pointing at the website as long as it’s up to date, I think the xiph.org domain carries a bit more weight than a GitHub repository.
There was a problem hiding this comment.
xiph domain may carry more weight, but like that, this will be the changelog for version 1.5.0:
https://xiph.org/flac/changelog.html
when it could have been:
https://github.com/xiph/flac/releases/tag/1.5.0
meanwhile, this could have been the changelog for version 1.3.3:
https://github.com/xiph/flac/releases/tag/1.3.3
but it's this:
https://xiph.org/flac/changelog.html (have fun scrolling)
if I haven't changed your mind, I will revert it
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.