-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
llvmPackages_17.{clang,tblgen}: fix builds on aarch64 #381163
base: master
Are you sure you want to change the base?
Conversation
I tried running |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Diff LGTM, I'll spin up an aarch64-linux build tonight after work.
5363aaa
to
496f940
Compare
moved new patch next to other |
there are not many packages which require llvm-17 on aarch64 linux (according to https://malob.github.io/nix-review-tools-reports/nixpkgs:trunk/nixpkgs_trunk_1811789.html) outside of the llvm-17 package set:
and rather use some patch in an unmerged PR which seems non-trivial to verify if it has any unintended side-effects just marking llvm-17 broken on aarch64-linux seems like a better option to me. |
It's possible that the
Makes sense. I lack experience to judge potential side-effects. I needed this change because I tried to use swift 6.0 but faced other issues with it further down the road and resigned in favor of docker. Thought I'll just submit a patch as I had it working |
Fixes #371077
Applies the patch proposed in the llvm issue. The fix will not make it to the llvm itself as they don't accept fixes for old release branches due to the complexity of the process.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.