Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvmPackages_17.{clang,tblgen}: fix builds on aarch64 #381163

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zvolin
Copy link
Contributor

@zvolin zvolin commented Feb 11, 2025

Fixes #371077

Applies the patch proposed in the llvm issue. The fix will not make it to the llvm itself as they don't accept fixes for old release branches due to the complexity of the process.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@zvolin
Copy link
Contributor Author

zvolin commented Feb 11, 2025

I tried running nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD" but it wanted to build so many packages that I was afraid of my (limited) disk space

Copy link
Member

@RossComputerGuy RossComputerGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Diff LGTM, I'll spin up an aarch64-linux build tonight after work.

@RossComputerGuy RossComputerGuy self-assigned this Feb 11, 2025
@zvolin zvolin force-pushed the fix/llvm17-aarch64 branch from 5363aaa to 496f940 Compare February 12, 2025 09:48
@zvolin
Copy link
Contributor Author

zvolin commented Feb 12, 2025

moved new patch next to other clang ones in getVersionFile

@paparodeo
Copy link
Contributor

paparodeo commented Feb 12, 2025

there are not many packages which require llvm-17 on aarch64 linux (according to https://malob.github.io/nix-review-tools-reports/nixpkgs:trunk/nixpkgs_trunk_1811789.html) outside of the llvm-17 package set:

  • clipbuzz.aarch64-linux
  • haskellPackages.llvm-codegen.aarch64-linux
  • ly.aarch64-linux
  • mepo.aarch64-linux
  • mlir_17.aarch64-linux
  • rivercarro.aarch64-linux
  • zig_0_12.aarch64-linux

and rather use some patch in an unmerged PR which seems non-trivial to verify if it has any unintended side-effects just marking llvm-17 broken on aarch64-linux seems like a better option to me.

@zvolin
Copy link
Contributor Author

zvolin commented Feb 13, 2025

there are not many packages which require llvm-17 on aarch64 linux

It's possible that the nixpkgs-review command tried to rebuild everything that depends on llvm then (without -17).

and rather use some patch in an unmerged PR which seems non-trivial to verify if it has any unintended side-effects just marking llvm-17 broken on aarch64-linux seems like a better option to me.

Makes sense. I lack experience to judge potential side-effects. I needed this change because I tried to use swift 6.0 but faced other issues with it further down the road and resigned in favor of docker. Thought I'll just submit a patch as I had it working

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: llvm/clang Issues related to llvmPackages, clangStdenv and related 10.rebuild-darwin: 101-500 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: llvmPackages_17.clang
3 participants