rustPlatform.defaultCrateOverrides: adding native support for PyO3 and mlua-sys #381161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
10.rebuild-darwin: 0
alyssais
reviewed
Feb 11, 2025
| @@ -270,6 +302,11 @@ in | |||
| nativeBuildInputs = [ protobuf ]; | |||
| }; | |||
|
|
|||
| pyo3 = attrs: { | |||
| nativeBuildInputs = [ pkg-config ]; | |||
| extraLinkFlags = [ "-L${python3}/lib" "-l${python3.libPrefix}" ]; | |||
There was a problem hiding this comment.
It needs pkg-config, but then also needs you to manually specify the link flags rather than getting them from pkg-config?
There was a problem hiding this comment.
This is because different versions and feature sets complain about different things. This does work though. PyO3 is a bit special, I'd like to also add a variant of buildRustCrate specifically to produce Python wheel from dependents of PyO3.
There was a problem hiding this comment.
If it changed in some version, might be clearer to handle the before/after separately.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.