Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

arma3-unix-launcher: 413 -> 413-unstable-2025-02-10 #381084

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

DrymarchonShaun
Copy link
Contributor

@DrymarchonShaun DrymarchonShaun commented Feb 11, 2025

Adds support for the new Expeditionary Forces DLC

Also changed disable_steam_integration.patch to invert the --disable-steam-integration command line option instead of disabling steam integration entirely in the event someone wants to re-enable it. (It's currently bugged, the game fails to launch with it enabled; see muttleyxd/arma3-unix-launcher#284)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

this patch was disabling steam integration entirely, updating it to
instead invert the --disable-steam-integration option so that its
disabled by default (there's a bug that stops the game from launching
with steam-integration enabled - see muttleyxd/arma3-unix-launcher#284
for more info)
Copy link
Member

@keenanweaver keenanweaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have Expeditionary Forces yet, but it builds & works for me.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 381084


x86_64-linux

✅ 1 package built:
  • arma3-unix-launcher

@keenanweaver keenanweaver added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Feb 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants