Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

buildFHSEnv: bind /nix as read-write #381032

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

james-atkins
Copy link
Contributor

Tweak bubblewrap options so /nix is mounted read-write rather than read-only: this is required for running a proprietary installer that requires an FHS environment. Ran into this when trying to package Matlab (#356831).

Fixes #239017.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

This is required for running a proprietary installer that requires an FHS environment.
Fixes NixOS#239017.
@james-atkins james-atkins requested a review from Atemu February 11, 2025 00:52
@nix-owners nix-owners bot requested a review from philiptaron February 11, 2025 00:53
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500 labels Feb 11, 2025
@philiptaron
Copy link
Contributor

I'm a little loathe to merge this. It's a pretty big increase in what applications are hypothetically able to do. Shouldn't this be a derivation-by-derivation decision?

@james-atkins
Copy link
Contributor Author

The nix store is mounted read-only at a lower level so this change shouldn't affect what wrapped applications are able to do, I think. But I would be happy to add a per-derivation flag.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 101-500
Projects
None yet
Development

Successfully merging this pull request may close these issues.

buildFHSEnv mounts /nix/store read-only and prevents FHS-installers from running.
3 participants