Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins.rainbow-delimiters-nvim: unstable-2025-01-12 -> 0.8.0 #380966

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

khaneliman
Copy link
Contributor

@khaneliman khaneliman commented Feb 10, 2025

Also changed to use the github mirror

Closes #380952 (comment)

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.


src = fetchFromGitLab {
src = fetchFromGitHub {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it can use GitHub, it should go to the automatic updater

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went back and forth in my head, I don't mind it being here to get stable updates until we figure out the stable pinning inside the main set. Not sure what everyone else thinks if we want to just roll back there again for unstable updates again

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh wait, GItHub is just a mirror

HiPhish/rainbow-delimiters.nvim#105 (comment)

We should not use mirrors without a reason, and instead target the main developer platform (IMO)

@PerchunPak
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380966


x86_64-linux

✅ 2 packages built:
  • vimPlugins.rainbow-delimiters-nvim
  • vimPluginsUpdater

aarch64-linux

✅ 2 packages built:
  • vimPlugins.rainbow-delimiters-nvim
  • vimPluginsUpdater

x86_64-darwin

✅ 2 packages built:
  • vimPlugins.rainbow-delimiters-nvim
  • vimPluginsUpdater

aarch64-darwin

✅ 2 packages built:
  • vimPlugins.rainbow-delimiters-nvim
  • vimPluginsUpdater

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants