nixos/autobrr: update service configuration #380826
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
use provided service package instead of system pkgs, update default values, and use systemd credentials for secretFile
github-actions
bot
added
6.topic: nixos
NixOSInfra
added
the
12. first-time contribution
github-actions
bot
added
10.rebuild-darwin: 0
ambroisie
approved these changes
Feb 10, 2025
wegank
added
the
12.approvals: 1
|
Thanks for the feedback @ambroisie, I'll be sure to split out the commits per specific change next time! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the autobrr service a few areas:
packageoption has been updated to use the provided package in the service configuration over using the system's package. Previously the option was unused and caused all current stable/versionedpkgsto not have the package available and fails to rebuild without doing additional overlays or overrides.portvariable to be a number.Tested on 24.11 and successfully running the service after importing the service configuration via the unstable nixpkgs input.
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.