Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

truecrack: fix build on gcc-14 #380703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

petrzjunior
Copy link
Contributor

@petrzjunior petrzjunior commented Feb 9, 2025

Truecrack is unmaintained upstream, but Kali Linux publishes patches to keep it building.

In this PR:

  • Update Kali patches to 0kali4
  • Fix build error reporting return; where int is expected
  • Add version check
  • Add install check using the test files which are present in the upstream repo

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@petrzjunior
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review-gha

Command: nixpkgs-review pr 380703

Logs: https://github.com/petrzjunior/nixpkgs-review-gha/actions/runs/13228925809


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • truecrack-cuda
✅ 1 package built:
  • truecrack

aarch64-linux

⏩ 1 package marked as broken and skipped:
  • truecrack-cuda
✅ 1 package built:
  • truecrack

x86_64-darwin

⏩ 1 package marked as broken and skipped:
  • truecrack-cuda
❌ 1 package failed to build:
  • truecrack

aarch64-darwin

⏩ 1 package marked as broken and skipped:
  • truecrack-cuda
✅ 1 package built:
  • truecrack

@ethancedwards8
Copy link
Member

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 380703


aarch64-darwin

⏩ 1 package marked as broken and skipped:
  • truecrack-cuda
✅ 1 package built:
  • truecrack

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants