Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: init lib.fallback #380605

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

lib: init lib.fallback #380605

wants to merge 3 commits into from

Conversation

hsjobeki
Copy link
Contributor

@hsjobeki hsjobeki commented Feb 9, 2025

Reasoning behind this:

  • if foo == [ ] then foo else something is verbose to type. I especially dont like to type foo twice since it can be very long in some cases (some.options.path.nested.attrs)

Some quick grep on gitub yielded this where it could be used:

I also found that

lib.fallback a b (a: a) might make sense instead.

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Copy link
Member

@infinisil infinisil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you link to some example code that would benefit from this?

Not a fan of the weak typing, there's no precedent for "truthy/falsy" in lib, and I'm not missing it, because it can give confusing results.

@hsjobeki
Copy link
Contributor Author

Can you link to some example code that would benefit from this?

Not a fan of the weak typing, there's no precedent for "truthy/falsy" in lib, and I'm not missing it, because it can give confusing results.

Hm yeah. Maybe it makes more sense to speak about the value beeing 'empty' or 'neutral'. Establishing a better mental model than thruthy/falsey.

I'll also add some links where this could been used to the description.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: lib The Nixpkgs function library 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants