-
-
Notifications
You must be signed in to change notification settings - Fork 14.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
linuxManualConfig: keep *.dtsi in dev output #379794
base: master
Are you sure you want to change the base?
Conversation
It may be a better option to just use |
the *.dtsi files can also be found under scripts/dtc/include-prefixes/ .So i will close this pr. |
the *.dtsi files can also be found under scripts/dtc/include-prefixes/ , but they are symlink to *.dtsi files under $buildRoot/arch/$linuxArch/boot/dts, |
Two reason for not using kernel.src.
Finaly, we have to do unpack/patch/install jobs to make a source package including *.dtsi files. |
|
Directory scripts/dtc/include-prefixes take responsible for compiling out-of-tree dts. Nixos have a device-tree module utilizing this directoy in linux^dev for compiling dtbo.
So why not keeping the *.dtsi file for compiling dtb. |
I found it very hard compiling out-of-tree devicetree in nixpkgs (not the devicetree overlay blob) , since most of the third-part devicetree require the .dtsi include file under arch/"$arch"/boot/dts directory which will be deleted during cleanup phase.
So one have to download and extract the kernel source again (and maybe patch the souce again).
Currently, the standard way to support out-of-tree board is to patch the kernel source, including copying the devicetree source file, patching the makefile. Which is not a vanilla work.
With this patch, and also some modification on nixos/device-tree module , we can support out-of-tree boards with the given dts file easily.
Things done
nix.conf
? (See Nix manual)sandbox = relaxed
sandbox = true
nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD"
. Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/
)Add a 👍 reaction to pull requests you find important.