Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

plots: drop #379516

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

plots: drop #379516

wants to merge 1 commit into from

Conversation

sund3RRR
Copy link
Contributor

@sund3RRR sund3RRR commented Feb 5, 2025

Things done

Plots has lack of upstream activity (latest tag was 2 years ago), so it does not work with GLSL > 3.20:

OpenGL ES version: 3.1
Traceback (most recent call last):
  File "/nix/store/r7v17p5gny60gliyq71y7ldfivpgsy6i-plots-0.8.5/lib/python3.12/site-packages/plots/graph.py", line 129, in gl_realize
    self.vertex_shader = shaders.compileShader(
                         ^^^^^^^^^^^^^^^^^^^^^^
  File "/nix/store/9rhm04ph4n39aj0vrnbqbbxbxd2c7rhh-python3.12-pyopengl-3.1.7/lib/python3.12/site-packages/OpenGL/GL/shaders.py", line 235, in compileShader
    raise ShaderCompilationError(
OpenGL.GL.shaders.ShaderCompilationError: ("Shader compile failure (0): b'0:20(10): error: GLSL 3.30 is not supported. Supported versions are: 1.00 ES, 3.00 ES, 3.10 ES, and 3.20 ES\\n'", [b'/*\n   Copyright 2021 Alexander Huntley\n\n   This file is part of Plots.\n\n   Plots is free software: you can redistribute it and/or modify\n   it under the terms of the GNU General Public License as published by\n   the Free Software Foundation, either version 3 of the License, or\n   (at your option) any later version.\n\n   Plots is distributed in the hope that it will be useful,\n   but WITHOUT ANY WARRANTY; without even the implied warranty of\n   MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the\n   GNU General Public License for more details.\n\n   You should have received a copy of the GNU General Public License\n   along with Plots.  If not, see <https://www.gnu.org/licenses/>.\n*/\n\n#version 330 core\nlayout (location = 0) in vec3 position;\nout vec2 graph_pos;\nuniform vec2 viewport;\nuniform vec2 translation;\nuniform float scale;\n\nvoid main() {\n    gl_Position = vec4(position, 1.0);\n    vec2 normalised = position.xy * viewport / viewport.x;\n    graph_pos = normalised*scale - translation;\n}'], GL_VERTEX_SHADER)

It has also been completely replaced by gnome-graphs, which is presented in nixpkgs.

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@@ -1097,6 +1097,7 @@ mapAliases {
pipewire_0_2 = throw "pipewire_0_2 has been removed as it is outdated and no longer used"; # Added 2024-07-28
pipewire-media-session = throw "pipewire-media-session is no longer maintained and has been removed. Please use Wireplumber instead.";
pleroma-otp = throw "'pleroma-otp' has been renamed to/replaced by 'pleroma'"; # Converted to throw 2024-10-17
plots = throw "'plots' has been replaced by 'gnome-graphs'";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
plots = throw "'plots' has been replaced by 'gnome-graphs'";
plots = throw "'plots' has been replaced by 'gnome-graphs'"; # Added 2025-02-05

@sund3RRR sund3RRR requested a review from Aleksanaa February 12, 2025 18:14
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: clean-up 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants